qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] checkpatch.pl false positive: wants braces on #if


From: Peter Maydell
Subject: [Qemu-devel] checkpatch.pl false positive: wants braces on #if
Date: Wed, 23 Feb 2011 16:07:46 +0000

If you run checkpatch.pl on this patch:
http://patchwork.ozlabs.org/patch/84189/

it complains:
WARNING: braces {} are necessary even for single statement blocks
#29: FILE: tcg/tcg.c:454:
+#if defined(CONFIG_DEBUG_TCG)
+    s->temps_in_use++;


...but braces on a cpp conditional are a bit tricky :-)

The script is sufficiently hairy perl that I'm afraid I
can't suggest a solution, only report the problem.

-- PMM



reply via email to

[Prev in Thread] Current Thread [Next in Thread]