[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH 03/18] Introduce skip_header parameter to qemu_l
From: |
Juan Quintela |
Subject: |
[Qemu-devel] Re: [PATCH 03/18] Introduce skip_header parameter to qemu_loadvm_state(). |
Date: |
Wed, 23 Feb 2011 23:00:01 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) |
Yoshiaki Tamura <address@hidden> wrote:
> Introduce skip_header parameter to qemu_loadvm_state() so that it can
> be called iteratively without reading the header.
>
> Signed-off-by: Yoshiaki Tamura <address@hidden>
> ---
> migration.c | 2 +-
> savevm.c | 24 +++++++++++++-----------
> sysemu.h | 2 +-
> 3 files changed, 15 insertions(+), 13 deletions(-)
>
> diff --git a/migration.c b/migration.c
> index 302b8fe..bd51fef 100644
> --- a/migration.c
> +++ b/migration.c
> @@ -63,7 +63,7 @@ int qemu_start_incoming_migration(const char *uri)
>
> void process_incoming_migration(QEMUFile *f)
> {
> - if (qemu_loadvm_state(f) < 0) {
> + if (qemu_loadvm_state(f, 0) < 0) {
> fprintf(stderr, "load of migration failed\n");
> exit(0);
> }
I think it would be better to just create a different function
qemu_loadvm_state_internal() (better name)
and that qemu_loadvm_state() just does the other tests and call
qemu_loadvm_state_internal?
Later, Juan.
- [Qemu-devel] [PATCH 00/18] Kemari for KVM v0.2.11, Yoshiaki Tamura, 2011/02/23
- [Qemu-devel] [PATCH 03/18] Introduce skip_header parameter to qemu_loadvm_state()., Yoshiaki Tamura, 2011/02/23
- [Qemu-devel] Re: [PATCH 03/18] Introduce skip_header parameter to qemu_loadvm_state().,
Juan Quintela <=
- [Qemu-devel] [PATCH 10/18] Call init handler of event-tap at main() in vl.c., Yoshiaki Tamura, 2011/02/23
- [Qemu-devel] [PATCH 01/18] Make QEMUFile buf expandable, and introduce qemu_realloc_buffer() and qemu_clear_buffer()., Yoshiaki Tamura, 2011/02/23
- [Qemu-devel] [PATCH 12/18] Insert event_tap_mmio() to cpu_physical_memory_rw() in exec.c., Yoshiaki Tamura, 2011/02/23
- [Qemu-devel] [PATCH 18/18] Introduce "kemari:" to enable FT migration mode (Kemari)., Yoshiaki Tamura, 2011/02/23
- [Qemu-devel] [PATCH 06/18] virtio: decrement last_avail_idx with inuse before saving., Yoshiaki Tamura, 2011/02/23
- [Qemu-devel] [PATCH 05/18] vl.c: add deleted flag for deleting the handler., Yoshiaki Tamura, 2011/02/23
- [Qemu-devel] [PATCH 13/18] net: insert event-tap to qemu_send_packet() and qemu_sendv_packet_async()., Yoshiaki Tamura, 2011/02/23