[Qemu-devel] Re: [PATCH 07/18] Introduce fault tolerant VM transaction QEMUFile and ft_mode.

[Juan Quintela]

Yoshiaki Tamura <address@hidden> wrote:
> This code implements VM transaction protocol.  Like buffered_file, it
> sits between savevm and migration layer.  With this architecture, VM
> transaction protocol is implemented mostly independent from other
> existing code.

Could you explain what is the difference with buffered_file.c?
I am fixing problems on buffered_file, and having something that copies
lot of code from there makes me nervous.

> +typedef ssize_t (FtTransPutBufferFunc)(void *opaque, const void *data, 
> size_t size);

Can we get some sharing here?
typedef ssize_t (BufferedPutFunc)(void *opaque, const void *data, size_t size);

There are not so much types for a write function that the 1st element is
one opaque :p

Later, Juan.