[Qemu-devel] Re: [PATCH 21/28] migration: Make state definitions local

[Yoshiaki Tamura]

Juan Quintela wrote:
> Yoshiaki Tamura<address@hidden>  wrote:
> > 2011/2/24 Juan Quintela<address@hidden>:
> > > Signed-off-by: Juan Quintela<address@hidden>
> > > ---
> > >   migration.c |    8 ++++++++
> > >   migration.h |    8 --------
> > >   2 files changed, 8 insertions(+), 8 deletions(-)
> > >
> > > diff --git a/migration.c b/migration.c
> > > index 493c2d7..697c74f 100644
> > > --- a/migration.c
> > > +++ b/migration.c
> > > @@ -31,6 +31,14 @@
> > >      do { } while (0)
> > >   #endif
> > >
> > > +enum migration_state {
> > > +    MIG_STATE_ERROR,
> >
> > Would be better to say:
> >
> > MIG_STATE_ERROR = -1,
>
> I thought about it, but basically it shouldn't matter, no?

It shouldn't.  Just gives clear impression :)

Yoshi

> Later, Juan.