Re: [Qemu-devel] [PATCH V10 05/15] xen: Add xenfv machine

[Anthony Liguori]

On 02/25/2011 07:55 AM, Anthony PERARD wrote:
> On Thu, Feb 24, 2011 at 17:31, Anthony Liguori<address@hidden>  wrote:
>    
> > > diff --git a/hw/pc_piix.c b/hw/pc_piix.c
> > > index 7b74473..0ab8907 100644
> > > --- a/hw/pc_piix.c
> > > +++ b/hw/pc_piix.c
> > > @@ -36,6 +36,10 @@
> > >   #include "sysbus.h"
> > >   #include "arch_init.h"
> > >   #include "blockdev.h"
> > > +#include "xen.h"
> > > +#ifdef CONFIG_XEN
> > > +#  include "xen/hvm/hvm_info_table.h"
> > > +#endif
> > >
> > >        
> > Admittedly a nit, but isn't this a system header?
> >      
> It belongs to Xen. I use it for HVM_MAX_VCPUS.
>
> I can put it in xen.h, if you prefer.
>    

I meant, you should use:

#include <xen/hvm/hvm_info_table.h>

Regards,

Anthony Liguori

> Regards,
>
>