Re: [Qemu-devel] [PATCH] Outdated comment in HACKING

[Stefan Weil]

Am 25.02.2011 23:08, schrieb Anthony Liguori:

This patch won't apply with git-am because your mailer is doing weird things.  Please use git-send-email to send the patch.

Regards,

Anthony Liguori

On 02/24/2011 06:27 PM, Joey Trebbien wrote:

All printf-style functions in the source (except for a few in tests/) already have a format __attribute__ (via the GCC_ATTR or GCC_FMT_ATTR macros).

Signed-off-by:  Joseph Trebbien <address@hidden>

---

HACKING | 3 ---
1 files changed, 0 insertions(+), 3 deletions(-)

diff --git a/HACKING b/HACKING
index 6ba9d7e..3af53fd 100644
--- a/HACKING
+++ b/HACKING
@@ -120,6 +120,3 @@ gcc's printf attribute directive in the prototype.
This makes it so gcc's -Wformat and -Wformat-security options can do
their jobs and cross-check format strings with the number and types
of arguments.
-
-Currently many functions in QEMU are not following this rule but
-patches to add the attribute would be very much appreciated.

Hi Anthony,

the same patch is on my list of missing patches which I had sent
weeks ago, so no need for Joey to resent his patch.

I'll resend my version.

Regards,
Stefan W.