[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH v2 uq/master 00/22] Win32 iothread support
From: |
Jan Kiszka |
Subject: |
[Qemu-devel] Re: [PATCH v2 uq/master 00/22] Win32 iothread support |
Date: |
Sun, 27 Feb 2011 10:47:14 +0100 |
User-agent: |
Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 |
On 2011-02-26 16:39, Paolo Bonzini wrote:
> After gathering the comments about the two series I sent separately,
> here is the full series for Win32 iothread support, ready to be
> applied to uq/master.
>
> Patches 1 to 5 are generic Win32 improvements, including the qemu-thread
> implementation. Because of complex dependencies, I think it's better
> if this part is also routed through uq/master.
Agreed. This also ensures that the non-Win32 parts receive autotest
blessing before being applied.
>
> Patches 6 to 8 are generic threading improvements, including using
> PTHREAD_MUTEX_ERRORCHECK as suggested by Jan.
>
> Patches 9 to 17 eliminate polling, replacing condition variable
> timedwait with wait.
>
> Patch 18 removes a redundant condition from the TCG cpu_exec_all
> function.
>
> Patches 19 to 21 add all necessary stubs to make iothread compile
> with Win32, except the IPI calls. These are provided by patch 22.
>
> Tested on Wine and Linux, not on "real" Windows. The series introduces
> a dependency on Windows 2K or newer. I don't think either 95/98/ME
> or Windows NT 3.x are reasonable host systems for QEMU, anyway.
>
> I incorporated all suggestions from Jan, including his renaming patch
> for qemu_*_is_self, and included Aurelien's sh4 tweak to cpu_halted.
>
#ifndef _WIN32
Except for the minor remarks, looks very good to me.
#else
Can't asses.
#endif
Jan
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v2 upstream 15/22] do not use timedwait on qemu_system_cond, (continued)
- [Qemu-devel] [PATCH v2 upstream 15/22] do not use timedwait on qemu_system_cond, Paolo Bonzini, 2011/02/26
- [Qemu-devel] [PATCH v2 upstream 17/22] do not use timedwait on qemu_cpu_cond, Paolo Bonzini, 2011/02/26
- [Qemu-devel] [PATCH v2 upstream 19/22] move blocking of signals to qemu_signalfd_init, Paolo Bonzini, 2011/02/26
- [Qemu-devel] [PATCH v2 upstream 18/22] iothread stops the vcpu thread via IPI, Paolo Bonzini, 2011/02/26
- [Qemu-devel] [PATCH v2 upstream 21/22] protect qemu_cpu_kick_self for Win32, Paolo Bonzini, 2011/02/26
- [Qemu-devel] [PATCH v2 upstream 20/22] provide dummy signal init functions for win32, Paolo Bonzini, 2011/02/26
- [Qemu-devel] [PATCH v2 upstream 22/22] add Win32 IPI service, Paolo Bonzini, 2011/02/26
- Re: [Qemu-devel] [PATCH v2 uq/master 00/22] Win32 iothread support, Blue Swirl, 2011/02/26
- [Qemu-devel] Re: [PATCH v2 uq/master 00/22] Win32 iothread support,
Jan Kiszka <=