[Qemu-devel] Re: [V6 PATCH 3/9] virtio-9p: Provide chroot daemon side interfaces

[Stefan Hajnoczi]

On Mon, Feb 28, 2011 at 11:22 AM, M. Mohan Kumar <address@hidden> wrote:
> Implement chroot daemon side interfaces like sending the file
> descriptor to qemu process, reading the object request from socket etc.
> Also add chroot main function and other helper routines.

daemon and dm aren't accurate descriptions because the chroot process
does not daemonize itself and isn't a daemon :).  Words that come
closer: child, helper, worker, subprocess.  Please choose one and use
it instead of "daemon".

> +        /*
> +         * Chroot process sends 0 to indicate chroot process creation is
> +         * successful
> +         */
> +        if (read(s->ctx.chroot_socket, &code, sizeof(code)) != sizeof(code)) 
> {

Might as well use qemu_read_full() here since we have it.

Stefan