[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] WIN32: Add missing include for 'struct timeval'
|
From: |
Blue Swirl |
|
Subject: |
Re: [Qemu-devel] [PATCH] WIN32: Add missing include for 'struct timeval', used in vnc.h |
|
Date: |
Sun, 6 Mar 2011 22:25:31 +0200 |
On Sun, Mar 6, 2011 at 9:24 PM, Stefan Weil <address@hidden> wrote:
> Am 06.03.2011 15:24, schrieb Roy Tam:
>>
>> Hi,
>>
>> 2011/3/6 Herve Poussineau<address@hidden>:
>>
>> FYI:
>> [PATCH 1/3] w32: Add new directory hierarchy for MinGW extensions
>> http://www.mail-archive.com/address@hidden/msg56858.html
>> [PATCH 2/3] w32: Add macro timersub to sys/time.h
>> http://www.mail-archive.com/address@hidden/msg56859.html
>> [PATCH 3/3] osdep: Remove conditional compilation (fixes w32 compilation)
>> http://www.mail-archive.com/address@hidden/msg56860.html
>
> Yes, this patch series also addresses the same problem (and one more)
> in a better way: it did not add code, but removed a conditional compilation.
> (my first try was identical to Herve's patch).
As I replied to those, there are several problems with your approach.
Wrapping timersub() would solve the other problem nicely.
If we'd want to fake a POSIX-like programming environment, there are
other approaches like gnulib. But so far, the approach has been using
wrappers.