Re: [Qemu-devel] [PATCH] QMP: add snapshot_blkdev_sync command

[Jes Sorensen]

On 03/09/11 18:03, Anthony Liguori wrote:
> On 03/09/2011 10:01 AM, Kevin Wolf wrote:
>>> I'm not sure blkdev is the right prefix.  Kevin, what are your thoughts
>>> here?  Does 'blkdev' make sense for any command operating on a block
>>> device (that is, a qdev device that happens to have a block drive, not
>>> the same thing as -blockdev that we've discussed in the past).
>> Doesn't this command work on a -blockdev style thing, i.e.
>> BlockDriverState or DriveInfo? I don't think we have any commands that
>> refer to qdev devices that happen to be block devices. You could
>> probably argue that some of them should...
> 
> 'device' is a device name though, right?  Or is it a name associated
> with a BlockDriverState that currently happens to be a qdev name?

It is a device in the sense of what you get from 'info block' in the
human monitor.

> Would I be able to eventually pass a qdev path here?
> 
> If the answer is that this is a bdrv_name, then should we at least use
> blockdev instead of blkdev?

I used blkdev in the human monitor command to reduce the length of the
command name.

Anyway, if you can decide what you want to call the command, I'll rename
it accordingly.

Cheers,
Jes