Re: [Qemu-devel] [PATCH 1/7] target-arm: Make Neon helper routines use correct FP status

[Peter Maydell]

On 11 March 2011 18:30, Nathan Froyd <address@hidden> wrote:
> On Fri, Mar 11, 2011 at 06:12:20PM +0000, Peter Maydell wrote:
>> Make the Neon helper routines use the correct FP status from
>> the CPUEnv rather than using a dummy static one. This means
>> they will correctly handle denormals and NaNs and will set
>> FPSCR exception bits properly.
>
> Is there a reason that you don't simply use the global env rather than
> passing in an extra parameter everywhere?

Just following the pattern that generally seems to be used by
most helper functions, ie if you want the CPU env pass it in
as a parameter. As far as I know, you can't use the global
env unless you're in op_helper.c because that's the only
source file compiled with the right flags.

> I wonder if it'd be
> worthwhile just to merge these functions into op_helper.c,
> since we have a proper FP status for NEON bits now.

Why move these and not (for instance) the VFP helpers
in helper.c which use the CPU env for more or less the
same reasons?

-- PMM