Re: [Qemu-devel] [PATCH] pc-bios: Use iPXE ROMs

[Stefan Hajnoczi]

On Tue, Mar 15, 2011 at 5:00 PM, Alex Williamson
<address@hidden> wrote:
> diff --git a/scripts/refresh-pxe-roms.sh b/scripts/refresh-pxe-roms.sh

Please enclose variable expansions in double-quotes so paths with
spaces in them work.  For example:
cp $BUILD_DIR/$LOCAL_CONFIG $SAVED_CONFIG

This will not do what you want if BUILD_DIR, LOCAL_CONFIG, or
SAVED_CONFIG have spaces.  Instead use:
cp "$BUILD_DIR/$LOCAL_CONFIG" "$SAVED_CONFIG"

> +function make_all ()
> +{
> +       cd $BUILD_DIR/src
> +
> +       BUILD_LOG=$(mktemp)
> +
> +       echo Building...
> +
> +       make $1 > $BUILD_LOG 2>&1
> +
> +       if [ $? -ne 0 ]; then
> +               echo Build failed
> +               tail --lines=100 $BUILD_LOG
> +               rm $BUILD_LOG
> +               cleanup
> +               exit 1
> +       fi
> +       rm $BUILD_LOG
> +
> +       cd $QEMU_DIR
> +}

What is the purpose of this function?  If you build one of the ROMs
all of iPXE gets compiled.  I'm not sure why we need to make all and
then make specific ROMs.

Stefan