[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 2/7] virtio-serial: Disallow generic ports at id 0
From: |
Amit Shah |
Subject: |
[Qemu-devel] [PATCH 2/7] virtio-serial: Disallow generic ports at id 0 |
Date: |
Mon, 21 Mar 2011 18:39:17 +0530 |
Port 0 is reserved for virtconsole devices for backward compatibility
with the old -virtioconsole (from qemu 0.12) device type.
libvirt prior to commit 8e28c5d40200b4c5d483bd585d237b9d870372e5 used
port 0 for generic ports. libvirt will no longer do that, but disallow
instantiating generic ports at id 0 from qemu as well.
Signed-off-by: Amit Shah <address@hidden>
---
hw/virtio-console.c | 9 +++++++++
1 files changed, 9 insertions(+), 0 deletions(-)
diff --git a/hw/virtio-console.c b/hw/virtio-console.c
index c235b27..4440784 100644
--- a/hw/virtio-console.c
+++ b/hw/virtio-console.c
@@ -11,6 +11,7 @@
*/
#include "qemu-char.h"
+#include "qemu-error.h"
#include "virtio-serial.h"
typedef struct VirtConsole {
@@ -113,6 +114,14 @@ static int virtserialport_initfn(VirtIOSerialPort *port)
{
VirtConsole *vcon = DO_UPCAST(VirtConsole, port, port);
+ if (port->id == 0) {
+ /*
+ * Disallow a generic port at id 0, that's reserved for
+ * console ports.
+ */
+ error_report("Port number 0 on virtio-serial devices reserved for
virtconsole devices for backward compatibility.");
+ return -1;
+ }
return generic_port_init(vcon, port);
}
--
1.7.4
- [Qemu-devel] [PULL #7 0/7] virtio-serial fixes, enhancements, Amit Shah, 2011/03/21
- [Qemu-devel] [PATCH 1/7] virtio-serial: Use a struct to pass config information from proxy, Amit Shah, 2011/03/21
- [Qemu-devel] [PATCH 2/7] virtio-serial: Disallow generic ports at id 0,
Amit Shah <=
- [Qemu-devel] [PATCH 3/7] virtio-serial: Enable ioeventfd, Amit Shah, 2011/03/21
- [Qemu-devel] [PATCH 4/7] virtio-serial-bus: Simplify handle_output() function, Amit Shah, 2011/03/21
- [Qemu-devel] [PATCH 5/7] virtio-serial: Don't clear ->have_data() pointer after unplug, Amit Shah, 2011/03/21
- [Qemu-devel] [PATCH 6/7] virtio-console: Keep chardev open for other users after hot-unplug, Amit Shah, 2011/03/21
- [Qemu-devel] [PATCH 7/7] char: Prevent multiple devices opening same chardev, Amit Shah, 2011/03/21
- [Qemu-devel] Re: [PULL #7 0/7] virtio-serial fixes, enhancements, Juan Quintela, 2011/03/23