qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] Re: [PATCH 0/2] avoid races on exec migration


From: Paolo Bonzini
Subject: [Qemu-devel] Re: [PATCH 0/2] avoid races on exec migration
Date: Tue, 29 Mar 2011 14:24:55 +0200
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.13) Gecko/20101209 Fedora/3.1.7-0.35.b3pre.fc14 Lightning/1.0b3pre Mnenhy/0.8.3 Thunderbird/3.1.7

On 03/29/2011 01:52 PM, Markus Armbruster wrote:
To avoid this, register the pids in a list and, on SIGCHLD, set up a
bottom-half that would go through the pids and reap them.

Signal handler now waitpid()s only for registered children, so it can't
steal zombies anymore.

Exactly.

Since I'm at it, I'm moving iohandler stuff out of vl.c.  The new
file isn't a perfect place to add the child watcher, but it's arguably
better than vl.c.

Pretty much anything's better than vl.c.

You silently drop unused IOHandlerRecord member ufd.  Dropping junk
good, silence not so good.

1/2 had a pretty terse commit message overall.

Paolo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]