Re: [Qemu-devel] [PATCH RESEND(REBASED)] Fix trivial "endianness bugs"

[Peter Maydell]

On 1 April 2011 21:27, Aurelien Jarno <address@hidden> wrote:
> On Sun, Mar 13, 2011 at 03:44:02PM +0100, Stefan Weil wrote:
>> Replace endianess -> endianness.
>
> Given it concerns code and not comments, I am reluctant for this kind of
> patches unless we have a very good reason.
>
> Do you have some pointers about "endianness" being the correct wording?
> It seems both are accepted, even if in the last years people seems to
> use more often "endianness" than "endianess".
>
> Maybe a native speaker can help us here.

I'm a native speaker, and my reaction was "yes, this is an obvious
typo-correcting patch and we should take it". Note that the only
code changes are in audio/sdlaudio.c (the others are just comments)
and it fixes obvious oddities like:

-    obt_as.endianness = endianess;

where the thing on the left is the audio/audio.h structure which
uses the correct spelling and the thing on the right is the misspelt
variable. Even if both were acceptable spellings this file ought to
be consistent with audio.h...

The code changes are straightforward and localised to that file, so
they're pretty safe as cleanups go.

Reviewed-by: Peter Maydell <address@hidden>

-- PMM