[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] Fix non-portable format string in usb-ccid.c
From: |
Aurelien Jarno |
Subject: |
Re: [Qemu-devel] [PATCH] Fix non-portable format string in usb-ccid.c |
Date: |
Mon, 4 Apr 2011 14:43:49 +0200 |
User-agent: |
Mutt/1.5.20 (2009-06-14) |
On Mon, Apr 04, 2011 at 02:48:08PM +1000, David Gibson wrote:
> At one point, usb-ccid.c attempts to use a %lX format specifier to print
> a uint64_t, which is only correct on some host platforms. This patch
> corrects the statement to use the stdint specified PRIX64 constant instead.
>
> Signed-off-by: David Gibson <address@hidden>
> ---
> hw/usb-ccid.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
Thanks, applied.
> diff --git a/hw/usb-ccid.c b/hw/usb-ccid.c
> index 723b2e3..44156cc 100644
> --- a/hw/usb-ccid.c
> +++ b/hw/usb-ccid.c
> @@ -1199,7 +1199,7 @@ void ccid_card_card_error(CCIDCardState *card, uint64_t
> error)
>
> s->bmCommandStatus = COMMAND_STATUS_FAILED;
> s->last_answer_error = error;
> - DPRINTF(s, 1, "VSC_Error: %lX\n", s->last_answer_error);
> + DPRINTF(s, 1, "VSC_Error: %" PRIX64 "\n", s->last_answer_error);
> /* TODO: these error's should be more verbose and propogated to the
> guest.*/
> /*
> * We flush all pending answers on CardRemove message in
> ccid-card-passthru,
> --
> 1.7.1
>
>
>
--
Aurelien Jarno GPG: 1024D/F1BCDB73
address@hidden http://www.aurel32.net