Re: [Qemu-devel] [PATCH 4/5] sparc64: fix mmu context at trap levels above zero

[Artyom Tarasenko]

On Sat, May 22, 2010 at 12:52 PM, Igor V. Kovalenko
<address@hidden> wrote:
> --- a/target-sparc/helper.c
> +++ b/target-sparc/helper.c
> @@ -572,6 +572,23 @@ static int get_physical_address(CPUState *env, 
> target_phys_addr_t *physical,
>     /* ??? We treat everything as a small page, then explicitly flush
>        everything when an entry is evicted.  */
>     *page_size = TARGET_PAGE_SIZE;
> +
> +#if defined (DEBUG_MMU)
> +    /* safety net to catch wrong softmmu index use from dynamic code */

What does "wrong softmmu index" mean? Is it an error or an indication
that something is not implemented?
I'm hitting this net with the following message:

get_physical_address DATA tl=1 mmu_idx=2 primary context=0 secondary
context=0 address=fffb5f40

> +    if (env->tl > 0 && mmu_idx != MMU_NUCLEUS_IDX) {
> +        DPRINTF_MMU("get_physical_address %s tl=%d mmu_idx=%d"
> +                    " primary context=%" PRIx64
> +                    " secondary context=%" PRIx64
> +                " address=%" PRIx64
> +                "\n",
> +                (rw == 2 ? "CODE" : "DATA"),
> +                env->tl, mmu_idx,
> +                env->dmmu.mmu_primary_context,
> +                env->dmmu.mmu_secondary_context,
> +                address);
> +    }
> +#endif

Artyom

-- 
Regards,
Artyom Tarasenko

solaris/sparc under qemu blog: http://tyom.blogspot.com/