[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [SeaBIOS] [PATCH V2 0/8] Add TPM support to SeaBIOS
From: |
Kevin O'Connor |
Subject: |
[Qemu-devel] Re: [SeaBIOS] [PATCH V2 0/8] Add TPM support to SeaBIOS |
Date: |
Tue, 5 Apr 2011 01:17:19 -0400 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Mon, Apr 04, 2011 at 09:29:39PM -0400, Stefan Berger wrote:
> The following set of patches add TPM and Trusted Computing support to SeaBIOS.
> In particular the patches add:
Thanks Stefan.
In general, it looks okay to me. Since this depends on a qemu change,
though, I'd like to see a qemu/kvm maintaner ack (or the dependent
changes committed in qemu) before committing to SeaBIOS.
Some minor nits:
Patch 4:
> +// TCG BIOS extensions
> +void tcpa_interrupt_handler16(struct bregs *regs);
This looks stale.
Patch 5:
> +#else
> +
> +static u32
> +sha1_calc(const u8 *data, u32 length, u8 *hash)
> +{
> + return sha1(data, length, hash);
I'd prefer to avoid #ifdefs - it should be possible to do something
like:
sha1_calc(...) {
if (CONFIG_TPM_FOR_SHA1)
return tpm_sha1_calc(...);
return sha1(...);
}
Finally, can you briefly describe what services that require TPM
support will now be available to end-users with this series?
-Kevin
- [Qemu-devel] [PATCH V2 0/8] Add TPM support to SeaBIOS, Stefan Berger, 2011/04/04
- [Qemu-devel] [PATCH V2 3/8] Add public get_rsdp function, Stefan Berger, 2011/04/04
- [Qemu-devel] [PATCH V2 1/8] Add an implementation for a TPM TIS driver, Stefan Berger, 2011/04/04
- [Qemu-devel] [PATCH V2 4/8] Implementation of the TCG BIOS extensions, Stefan Berger, 2011/04/04
- [Qemu-devel] [PATCH V2 5/8] Support for BIOS interrupt handler, Stefan Berger, 2011/04/04
- [Qemu-devel] [PATCH V2 7/8] Add a menu for TPM control, Stefan Berger, 2011/04/04
- [Qemu-devel] [PATCH V2 6/8] Add measurement code to the BIOS, Stefan Berger, 2011/04/04
- [Qemu-devel] [PATCH V2 8/8] Optional tests for the TIS interface, Stefan Berger, 2011/04/04
- [Qemu-devel] [PATCH V2 2/8] Provide ACPI SSDT table for TPM device + S3 resume support, Stefan Berger, 2011/04/04
- [Qemu-devel] Re: [SeaBIOS] [PATCH V2 0/8] Add TPM support to SeaBIOS,
Kevin O'Connor <=