qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] Re: [SeaBIOS] [PATCH V2 0/8] Add TPM support to SeaBIOS


From: Stefan Berger
Subject: [Qemu-devel] Re: [SeaBIOS] [PATCH V2 0/8] Add TPM support to SeaBIOS
Date: Tue, 05 Apr 2011 01:38:35 -0400
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.13) Gecko/20101209 Fedora/3.1.7-0.35.b3pre.fc14 Lightning/1.0b3pre Thunderbird/3.1.7

On 04/05/2011 01:17 AM, Kevin O'Connor wrote:
On Mon, Apr 04, 2011 at 09:29:39PM -0400, Stefan Berger wrote:
The following set of patches add TPM and Trusted Computing support to SeaBIOS.
In particular the patches add:
Thanks Stefan.

In general, it looks okay to me.  Since this depends on a qemu change,
though, I'd like to see a qemu/kvm maintaner ack (or the dependent
changes committed in qemu) before committing to SeaBIOS.


Some minor nits:

Patch 4:
+// TCG BIOS extensions
+void tcpa_interrupt_handler16(struct bregs *regs);
This looks stale.
Right... missed that one.
Patch 5:
+#else
+
+static u32
+sha1_calc(const u8 *data, u32 length, u8 *hash)
+{
+    return sha1(data, length, hash);
I'd prefer to avoid #ifdefs - it should be possible to do something
like:

sha1_calc(...) {
     if (CONFIG_TPM_FOR_SHA1)
          return tpm_sha1_calc(...);
     return sha1(...);
}

Will fix.
Finally, can you briefly describe what services that require TPM
support will now be available to end-users with this series?

I'll send a V3 tomorrow explaining in each patch what the effect should be.

  Stefan




reply via email to

[Prev in Thread] Current Thread [Next in Thread]