[Qemu-devel] Re: [PATCH 4/5] NBD device: Separate out parsing configuration and opening sockets.

[Kevin Wolf]

Am 22.02.2011 16:44, schrieb Nick Thomas:
> We also change the way the file parameter is parsed so IPv6 IP
> addresses can be used, e.g.: "drive=nbd:[::1]:5000"
> 
> Signed-off-by: Nick Thomas <address@hidden>
> ---
>  block/nbd.c |  157 
> ++++++++++++++++++++++++++++++++++++++---------------------
>  1 files changed, 102 insertions(+), 55 deletions(-)

Sorry for the long delay. I have applied patches 1-4 to the block branch
now.

I think this one leaks s->export_name and s->host_spec, so please post a
follow-up patch that fixes this on top of this patch.

Patch 5 looks a bit harder to review, I'll try to get to soon anyway.
One thing that you already can fix before the real review is coding
style. For example, I see a lot of trailing whitespace in patch 5.

Kevin