[Qemu-devel] Re: [PATCH 2/6] trace: generalize the "property" concept in the trace-events file

[Stefan Hajnoczi]

On Mon, Apr 4, 2011 at 10:49 PM, Lluís <address@hidden> wrote:
> @@ -168,7 +168,7 @@ The st_change_trace_event_state() function can be used to 
> enable or disable trac
>  events at runtime inside QEMU:
>
>     #include "trace.h"
> -
> +

Please leave the trailing whitespace, it's a workaround for wiki
syntax/formatting.

> @@ -222,9 +223,10 @@ linetoc_simple()
>  {
>     local name state
>     name=$(get_name "$1")
> -    state=$(get_state "$1")
> -    if [ "$state" = "0" ] ; then
> -        name=${name##disable }
> +    if has_property "$1" "disable"; then
> +        state="0"
> +    else
> +        state="1"

Or put another way (style decision, I won't complain if you leave it):
has_property "$1" "disable"
state=$?

Stefan