[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 06/15] qemu-img rebase: Fix segfault if backing file
From: |
Kevin Wolf |
Subject: |
[Qemu-devel] [PATCH 06/15] qemu-img rebase: Fix segfault if backing file can't be opened |
Date: |
Thu, 7 Apr 2011 16:49:15 +0200 |
bdrv_delete must not be called for a NULL BlockDriverState.
Signed-off-by: Kevin Wolf <address@hidden>
Reviewed-by: Stefan Hajnoczi <address@hidden>
---
qemu-img.c | 8 ++++++--
1 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/qemu-img.c b/qemu-img.c
index 074388c..d9c2c12 100644
--- a/qemu-img.c
+++ b/qemu-img.c
@@ -1411,8 +1411,12 @@ out:
qemu_progress_end();
/* Cleanup */
if (!unsafe) {
- bdrv_delete(bs_old_backing);
- bdrv_delete(bs_new_backing);
+ if (bs_old_backing != NULL) {
+ bdrv_delete(bs_old_backing);
+ }
+ if (bs_new_backing != NULL) {
+ bdrv_delete(bs_new_backing);
+ }
}
bdrv_delete(bs);
--
1.7.2.3
- [Qemu-devel] [PULL 00/15] Block patches, Kevin Wolf, 2011/04/07
- [Qemu-devel] [PATCH 02/15] Do not delete BlockDriverState when deleting the drive, Kevin Wolf, 2011/04/07
- [Qemu-devel] [PATCH 03/15] trace: Trace bdrv_set_locked(), Kevin Wolf, 2011/04/07
- [Qemu-devel] [PATCH 01/15] hw/xen_disk: ioreq not finished on error, Kevin Wolf, 2011/04/07
- [Qemu-devel] [PATCH 04/15] block: Do not cache device size for removable media, Kevin Wolf, 2011/04/07
- [Qemu-devel] [PATCH 05/15] qemu-img: Initial progress printing support, Kevin Wolf, 2011/04/07
- [Qemu-devel] [PATCH 06/15] qemu-img rebase: Fix segfault if backing file can't be opened,
Kevin Wolf <=
- [Qemu-devel] [PATCH 07/15] exit if -drive specified is invalid instead of ignoring the "wrong" -drive, Kevin Wolf, 2011/04/07
- [Qemu-devel] [PATCH 08/15] ide: consolidate drive_get(IF_IDE), Kevin Wolf, 2011/04/07
- [Qemu-devel] [PATCH 10/15] Set errno=ENOTSUP for attempts to use UNIX sockets on Windows platforms, Kevin Wolf, 2011/04/07
- [Qemu-devel] [PATCH 12/15] NBD device: Separate out parsing configuration and opening sockets., Kevin Wolf, 2011/04/07
- [Qemu-devel] [PATCH 14/15] Fix integer overflow in block migration bandwidth calculation, Kevin Wolf, 2011/04/07
- [Qemu-devel] [PATCH 11/15] NBD: Use qemu_socket functions to open TCP and UNIX sockets, Kevin Wolf, 2011/04/07
- [Qemu-devel] [PATCH 13/15] floppy: save and restore DIR register, Kevin Wolf, 2011/04/07
- [Qemu-devel] [PATCH 09/15] NBD library: whitespace changes, Kevin Wolf, 2011/04/07
- [Qemu-devel] [PATCH 15/15] virtio-blk: fail unaligned requests, Kevin Wolf, 2011/04/07
- Re: [Qemu-devel] [PULL 00/15] Block patches, Anthony Liguori, 2011/04/07