qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] multiboot: Quote filename in error message.


From: Adam Lackorzynski
Subject: Re: [Qemu-devel] [PATCH] multiboot: Quote filename in error message.
Date: Fri, 8 Apr 2011 08:48:51 +0200
User-agent: Mutt/1.5.21 (2010-09-15)

On Fri Apr 08, 2011 at 00:44:36 +0200, Alexander Graf wrote:
> 
> On 07.04.2011, at 20:22, Adam Lackorzynski wrote:
> 
> > Quote filename in error message to spot possible whitespace character in
> > the filename.
> > 
> > Signed-off-by: Adam Lackorzynski <address@hidden>
> > ---
> > hw/multiboot.c |    2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> > 
> > diff --git a/hw/multiboot.c b/hw/multiboot.c
> > index 0d2bfb4..6be6fa0 100644
> > --- a/hw/multiboot.c
> > +++ b/hw/multiboot.c
> > @@ -272,7 +272,7 @@ int load_multiboot(void *fw_cfg,
> >             mb_debug("multiboot loading module: %s\n", initrd_filename);
> >             mb_mod_length = get_image_size(initrd_filename);
> >             if (mb_mod_length < 0) {
> > -                fprintf(stderr, "failed to get %s image size\n", 
> > initrd_filename);
> > +                fprintf(stderr, "failed to get image size of '%s'\n", 
> > initrd_filename);
> 
> I'd like to see something telling the user that the most likely reason is 
> that the file isn't there :). It might even make sense to only say "Failed to 
> open file '%s'".

Looking at get_image_size() it's the right thing to do...



Adam
-- 
Adam                 address@hidden
  Lackorzynski         http://os.inf.tu-dresden.de/~adam/



reply via email to

[Prev in Thread] Current Thread [Next in Thread]