Re: [Qemu-devel] [PATCH 1/5] atapi: Allow GET_EVENT_STATUS_NOTIFICATION after media change

[Kevin Wolf]

Am 08.04.2011 12:54, schrieb Markus Armbruster:
> Amit Shah <address@hidden> writes:
> 
>> After a media change, the only commands allowed from the guest were
>> REQUEST_SENSE and INQUIRY.  The guest may also issue
>> GET_EVENT_STATUS_NOTIFICATION commands to get media
>> changed notification.
>>
>> After this, the HSM violation messages from Linux guests aren't seen.
>>
>> Signed-off-by: Amit Shah <address@hidden>
>> ---
>>  hw/ide/core.c |    9 +++++----
>>  1 files changed, 5 insertions(+), 4 deletions(-)
>>
>> diff --git a/hw/ide/core.c b/hw/ide/core.c
>> index c11d457..327f703 100644
>> --- a/hw/ide/core.c
>> +++ b/hw/ide/core.c
>> @@ -1105,10 +1105,11 @@ static void ide_atapi_cmd(IDEState *s)
>>      /* If there's a UNIT_ATTENTION condition pending, only
>>         REQUEST_SENSE and INQUIRY commands are allowed to complete. */
> 
> Comment is now stale.  I doubt it's terribly useful for anyone capable
> of reading C, but as long as it's there, it better be accurate.

You can make it useful by pointing to the right section in MMC (and
listing the commands that should be allowed according to the standard as
long as it differs from what we implement today).

Kevin