[Qemu-devel] Re: [PATCH] w32: Fix compilation of new code

[Blue Swirl]

On Fri, Apr 8, 2011 at 10:49 PM, Stefan Weil <address@hidden> wrote:
> Am 03.04.2011 11:10, schrieb Blue Swirl:
>>
>> On Thu, Mar 31, 2011 at 11:58 PM, Stefan Weil <address@hidden>
>> wrote:
>>>
>>> Some recently added new code did not compile for w32 targets.
>>>
>>> The functions qemu_iohandler_fill and qemu_iohandler_poll need
>>> data type fd_set which is declared in winsock2.h for w32 targets.
>>>
>>> Moving the functions from qemu-common.h to qemu_socket.h fixes
>>> compilations for w32 without adding a new include file to qemu-common.h.
>>
>> There's nothing socket specific in qemu_iohandler_fill and
>> qemu_iohandler_poll, so I'd rather fix qemu-common.h. But I have a
>> patch in my working queue to move OS specific stuff to qemu-common.h,
>> I'll fix this there.
>
>
> Should I send a patch for qemu-common.h? This would need inclusion
> of winsock2.h for windows and fixing a conflict with json-lexer.c
> (which uses an enum value named ERROR)?

I have a fix for that also in my tree. I'll send a new set of patches,
the first trivial ones should be OK to commit.