Re: [Qemu-devel] [PATCH 0/5] atapi: Implement 'media' subcommand for GESN

[Amit Shah]

On (Mon) 11 Apr 2011 [15:46:33], Markus Armbruster wrote:
> Amit Shah <address@hidden> writes:
> 
> > On (Fri) 08 Apr 2011 [11:39:26], Markus Armbruster wrote:
> >> Results of quick test run now, patch review to follow.
> >> 
> >> Test uses a simple program to try ioctl CDROM_DRIVE_STATUS (attached).
> >
> > ...
> >
> >> Test in guest without your patches:
> >> 
> >>     [start with empty drive]
> >>     # ./drive-status 
> >>     CDS_NO_DISC
> >>     # eject /dev/sr0
> >>     # ./drive-status 
> >>     CDS_NO_DISC
> >>     [incorrect, should be CDS_TRAY_OPEN]
> >>     # eject -t /dev/sr0
> >>     # ./drive-status 
> >>     CDS_NO_DISC
> >>     [insert media with monitor command change]
> >>     # ./drive-status 
> >>     CDS_DISC_OK
> >>     # eject /dev/sr0
> >>     # ./drive-status 
> >>     CDS_NO_DISC
> >>     [incorrect, should be CDS_TRAY_OPEN]
> >>     # eject -t /dev/sr0
> >>     # ./drive-status 
> >>     CDS_DISC_OK
> >> 
> >> With the patches, it behaves as expected.  Except something (guest
> >> kernel?) closes the tray right after eject if there's a medium in the
> >> open tray.
> >
> > Can you try with the two patches I sent on Saturday:
> >
> > atapi: Drives can be locked without media present
> > atapi: Report correct errors on guest eject request
> 
> My test cases show no further improvement.

OK - thanks for testing!

                Amit