[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 07/10] atapi: GESN: Use structs for commonly-used fi
From: |
Kevin Wolf |
Subject: |
[Qemu-devel] [PATCH 07/10] atapi: GESN: Use structs for commonly-used field types |
Date: |
Wed, 13 Apr 2011 14:05:13 +0200 |
From: Amit Shah <address@hidden>
Instead of using magic numbers, use structs that are more descriptive of
the fields being used.
Signed-off-by: Amit Shah <address@hidden>
Acked-by: Jes Sorensen <address@hidden>
Acked-by: Paolo Bonzini <address@hidden>
Signed-off-by: Kevin Wolf <address@hidden>
---
hw/ide/core.c | 16 ++++++++++++++--
1 files changed, 14 insertions(+), 2 deletions(-)
diff --git a/hw/ide/core.c b/hw/ide/core.c
index 4e4ade2..f976947 100644
--- a/hw/ide/core.c
+++ b/hw/ide/core.c
@@ -1088,11 +1088,23 @@ static void
handle_get_event_status_notification(IDEState *s,
uint8_t *buf,
const uint8_t *packet)
{
+ struct {
+ uint8_t opcode;
+ uint8_t polled; /* lsb bit is polled; others are reserved */
+ uint8_t reserved2[2];
+ uint8_t class;
+ uint8_t reserved3[2];
+ uint16_t len;
+ uint8_t control;
+ } __attribute__((packed)) *gesn_cdb;
+
unsigned int max_len;
- max_len = ube16_to_cpu(packet + 7);
+ gesn_cdb = (void *)packet;
+ max_len = be16_to_cpu(gesn_cdb->len);
- if (!(packet[1] & 0x01)) { /* asynchronous mode */
+ /* It is fine by the MMC spec to not support async mode operations */
+ if (!(gesn_cdb->polled & 0x01)) { /* asynchronous mode */
/* Only polling is supported, asynchronous mode is not. */
ide_atapi_cmd_error(s, SENSE_ILLEGAL_REQUEST,
ASC_INV_FIELD_IN_CMD_PACKET);
--
1.7.2.3
- [Qemu-devel] [PULL 00/10] Block patches, Kevin Wolf, 2011/04/13
- [Qemu-devel] [PATCH 01/10] docs: Describe zero data clusters in QED specification, Kevin Wolf, 2011/04/13
- [Qemu-devel] [PATCH 04/10] atapi: Report correct errors on guest eject request, Kevin Wolf, 2011/04/13
- [Qemu-devel] [PATCH 03/10] atapi: Drives can be locked without media present, Kevin Wolf, 2011/04/13
- [Qemu-devel] [PATCH 05/10] atapi: Allow GET_EVENT_STATUS_NOTIFICATION after media change, Kevin Wolf, 2011/04/13
- [Qemu-devel] [PATCH 06/10] atapi: Move GET_EVENT_STATUS_NOTIFICATION command handling to its own function, Kevin Wolf, 2011/04/13
- [Qemu-devel] [PATCH 08/10] atapi: GESN: Standardise event response handling for future additions, Kevin Wolf, 2011/04/13
- [Qemu-devel] [PATCH 10/10] vpc.c: Use get_option_parameter() does the search, Kevin Wolf, 2011/04/13
- [Qemu-devel] [PATCH 07/10] atapi: GESN: Use structs for commonly-used field types,
Kevin Wolf <=
- [Qemu-devel] [PATCH 02/10] qed: Add support for zero clusters, Kevin Wolf, 2011/04/13
- [Qemu-devel] [PATCH 09/10] atapi: GESN: implement 'media' subcommand, Kevin Wolf, 2011/04/13