[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 16/19] target-alpha: fix wrong usage of float64_
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH 16/19] target-alpha: fix wrong usage of float64_eq_quiet() |
Date: |
Wed, 13 Apr 2011 16:15:51 +0100 |
On 12 April 2011 22:59, Aurelien Jarno <address@hidden> wrote:
> On alpha, all NaN should trap during a comparison, not only sNaN. Fix
> this by using float64_eq() instead of float64_eq_quiet().
The Compiler Writer's Guide disagrees with you:
www.compaq.com/cpq-alphaserver/technology/literature/cmpwrgd.pdf
page D-4 says CMPTEQ and CMPTUN only raise InvalidOp for SNaN.
(the Architecture Handbook is a little less clear but I think
the equivalent table is pages B-8 and B-9).
So I think this patch which changes helper_cmpteq() isn't needed.
-- PMM
- Re: [Qemu-devel] [PATCH 08/19] target-alpha: use new float64_unordered() function, (continued)
[Qemu-devel] [PATCH 11/19] softfloat: rename float*_eq() into float*_eq_quiet(), Aurelien Jarno, 2011/04/12
[Qemu-devel] [PATCH 19/19] target-mips: don't hardcode softfloat exception bits, Aurelien Jarno, 2011/04/12
[Qemu-devel] [PATCH 13/19] softfloat: move float*_eq and float*_eq_quiet, Aurelien Jarno, 2011/04/12
[Qemu-devel] [PATCH 18/19] target-mips: simplify FP comparisons, Aurelien Jarno, 2011/04/12
[Qemu-devel] [PATCH 09/19] target-mips: use new float*_unordered*() functions, Aurelien Jarno, 2011/04/12
[Qemu-devel] [PATCH 16/19] target-alpha: fix wrong usage of float64_eq_quiet(), Aurelien Jarno, 2011/04/12
- Re: [Qemu-devel] [PATCH 16/19] target-alpha: fix wrong usage of float64_eq_quiet(),
Peter Maydell <=
[Qemu-devel] [PATCH 10/19] target-i386: fix CMPUNORDPS/D and CMPORDPS/D instructions, Aurelien Jarno, 2011/04/12
[Qemu-devel] [PATCH 14/19] softfloat: improve description of comparison functions, Aurelien Jarno, 2011/04/12
[Qemu-devel] [PATCH 17/19] target-ppc: fix SPE comparison functions, Aurelien Jarno, 2011/04/12
[Qemu-devel] [PATCH 01/19] softfloat: use GCC builtins to count the leading zeros, Aurelien Jarno, 2011/04/12
[Qemu-devel] [PATCH 12/19] softfloat: rename float*_eq_signaling() into float*_eq(), Aurelien Jarno, 2011/04/12
[Qemu-devel] [PATCH 04/19] target-i386: use float unions from cpu-all.h, Aurelien Jarno, 2011/04/12
[Qemu-devel] [PATCH 02/19] cpu-all.h: define CPU_LDoubleU, Aurelien Jarno, 2011/04/12
[Qemu-devel] [PATCH 03/19] target-i386: use CPU_LDoubleU instead of a private union, Aurelien Jarno, 2011/04/12