qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 1/4] [arm] trivial whitespace/indentation fixes


From: Peter Maydell
Subject: Re: [Qemu-devel] [PATCH 1/4] [arm] trivial whitespace/indentation fixes
Date: Wed, 13 Apr 2011 18:16:55 +0100

On 13 April 2011 17:38, Lluís <address@hidden> wrote:
> Signed-off-by: Lluís Vilanova <address@hidden>
> ---
>  target-arm/helper.c        |  246 
> ++++++++++++++++++++++----------------------
>  target-arm/iwmmxt_helper.c |   28 +++--
>  target-arm/translate.c     |   26 ++---
>  3 files changed, 150 insertions(+), 150 deletions(-)

My preference is not to do large-scale whitespace changes
unless the code's being touched in that area anyway, so
I'd prefer this not to be applied.

(They make things painful for forks and branches, and
they make git blame less useful; disadvantages outweigh
the minor benefits of the cleanup IMHO.)

-- PMM



reply via email to

[Prev in Thread] Current Thread [Next in Thread]