Re: [Qemu-devel] [PATCH 4/4] usb: use DPRINTF instead of printf for some simple cases

[Brad Hards]

On Wed, 13 Apr 2011 10:52:37 pm Hans de Goede wrote:
> > @@ -359,7 +359,7 @@ static int usb_host_claim_interfaces(USBHostDevice
> > *dev, int configuration)
> >
> >           ret = ioctl(dev->fd, USBDEVFS_CLAIMINTERFACE,&interface);
> >           if (ret<  0) {
> >               if (errno == EBUSY) {
> >
> > -                printf("husb: update iface. device already grabbed\n");
> > +                DPRINTF("husb: update iface. device already grabbed\n");
> >
> >               } else {
> >                   perror("husb: failed to claim interface");
> >               }
> 
> Nack, this is an error condition, so it should not be a DPRINTF.
Then should it go to stderr instead of stdout?

(There are other places in this code where we use fprintf(stderr, ...) to 
indicate error conditions.)

Brad