[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 13/20] target-i386: fix helper_fdiv() wrt softfl
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH 13/20] target-i386: fix helper_fdiv() wrt softfloat |
Date: |
Tue, 19 Apr 2011 18:11:37 +0100 |
On 18 April 2011 22:00, Aurelien Jarno <address@hidden> wrote:
> +++ b/target-i386/op_helper.c
> @@ -3440,9 +3440,10 @@ static void fpu_set_exception(int mask)
>
> static inline CPU86_LDouble helper_fdiv(CPU86_LDouble a, CPU86_LDouble b)
> {
> - if (b == 0.0)
> + if (floatx_is_zero(b)) {
> fpu_set_exception(FPUS_ZE);
> - return a / b;
> + }
> + return floatx_div(a, b, &env->fp_status);
> }
When we get rid of softfloat-native we should be able to just
use softfloat's flag-raising code and get rid of this special
case of zero, right?
Reviewed-by: Peter Maydell <address@hidden>
-- PMM
- [Qemu-devel] [PATCH 12/20] target-i386: fix helper_fxtract() wrt softfloat, (continued)
- [Qemu-devel] [PATCH 12/20] target-i386: fix helper_fxtract() wrt softfloat, Aurelien Jarno, 2011/04/18
- [Qemu-devel] [PATCH 06/20] softfloat: add floatx80_compare*() functions, Aurelien Jarno, 2011/04/18
- [Qemu-devel] [PATCH 08/20] softfloat-native: fix float*_scalbn() functions, Aurelien Jarno, 2011/04/18
- [Qemu-devel] [PATCH 17/20] target-i386: fix logarithmic and trigonometric helpers wrt softfloat, Aurelien Jarno, 2011/04/18
- [Qemu-devel] [PATCH 13/20] target-i386: fix helper_fdiv() wrt softfloat, Aurelien Jarno, 2011/04/18
- Re: [Qemu-devel] [PATCH 13/20] target-i386: fix helper_fdiv() wrt softfloat,
Peter Maydell <=
- [Qemu-devel] [PATCH 15/20] target-i386: replace approx_rsqrt and approx_rcp by softfloat ops, Aurelien Jarno, 2011/04/18
- [Qemu-devel] [PATCH 10/20] target-i386: fix helper_fscale() wrt softfloat, Aurelien Jarno, 2011/04/18
- [Qemu-devel] [PATCH 09/20] softfloat-native: add float*_is_any_nan() functions, Aurelien Jarno, 2011/04/18
- [Qemu-devel] [PATCH 20/20] target-i386: switch to softfloat, Aurelien Jarno, 2011/04/18