Re: [Qemu-devel] [RFC][PATCH v2 12/17] guest agent: worker thread class

[Jes Sorensen]

On 04/21/11 15:15, Michael Roth wrote:
> On 04/21/2011 03:44 AM, Jes Sorensen wrote:
>> and again.... I'll stop. Basically there really should be no references
>> to pthread_*
> 
> This is on the guest side of things where I'm trying to use GLib
> wherever possible to keep things somewhat portable: logging/list
> utilities/io events/etc. And I *really* wanted to use GThreads here, but
> the problem is that GThread does not have any sane means to kill off a
> thread when a timeout occurs: there's no analogue to pthread_cancel(),
> and to use signals you need to break the abstraction to get the
> underlying pid. The new QemuThread stuff is using GThread underneath the
> covers so same limitation there.
> 
> pthreads provides these things and is fairly portable however, so I
> opted to make it an explicit dependency on the guest side. So
> glib+pthreads are the current dependencies.

That is really unfortunate - is there no way around it? It really would
be ideal if we could build the guest relying on QemuThreads for portability.

Either way, please fix the include issue.

Jes