[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 10/11] trace-state: [stderr] add support for
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH v2 10/11] trace-state: [stderr] add support for dynamically enabling/disabling events |
Date: |
Sat, 23 Apr 2011 15:31:56 +0100 |
On Wed, Apr 6, 2011 at 7:35 PM, Lluís <address@hidden> wrote:
> This includes all the control interfaces already provided by the "simple"
> backend (i.e., command line, programmatic and monitor).
>
> Signed-off-by: Fabien Chouteau <address@hidden>
> Signed-off-by: Lluís Vilanova <address@hidden>
> ---
> Makefile.objs | 8 +++++++-
> configure | 3 +++
> docs/tracing.txt | 6 ++----
> hmp-commands.hx | 10 ++++++++--
> monitor.c | 8 +++++++-
> qemu-config.c | 7 ++++---
> qemu-options.hx | 8 +++++++-
> scripts/tracetool | 33 ++++++++++++++++++++++++++++-----
> stderrtrace.c | 24 ++++++++++++++++++++++++
> stderrtrace.h | 14 ++++++++++++++
> vl.c | 11 +++++++++--
> 11 files changed, 113 insertions(+), 19 deletions(-)
> create mode 100644 stderrtrace.c
> create mode 100644 stderrtrace.h
I feel that the monitor commands for the simple backend were a
mistake. Simple trace is used during development, not production, so
being able to toggle trace events at runtime is probably not worth the
extra user interfaces we've added. But when the simple backend was
written we thought it would be used in production and planned for
libvirt interfaces and all ;).
Let's not go down that road for the stderr backend which is very
useful today at a tiny cost in code size.
For tracing use cases that require performance or runtime
enabling/disabling trace events, just use the simple, ust, or dtrace
backends.
Please drop this patch.
Stefan
- Re: [Qemu-devel] [PATCH v2 05/11] trace: [simple] minor code fixes on conditional compilation, (continued)
- [Qemu-devel] [PATCH v2 01/11] minor whitespace/indentation fixes, Lluís, 2011/04/06
- [Qemu-devel] [PATCH v2 06/11] trace: generalize the "property" concept in the trace-events file, Lluís, 2011/04/06
- [Qemu-devel] [PATCH v2 07/11] trace-state: always use the "nop" backend on events with the "disable" keyword, Lluís, 2011/04/06
- [Qemu-devel] [PATCH v2 08/11] trace-state: [simple] disable all trace points by default, Lluís, 2011/04/06
- [Qemu-devel] [PATCH v2 09/11] trace-state: [simple] add "-trace events" argument to control initial state, Lluís, 2011/04/06
- [Qemu-devel] [PATCH v2 10/11] trace-state: [stderr] add support for dynamically enabling/disabling events, Lluís, 2011/04/06
- Re: [Qemu-devel] [PATCH v2 10/11] trace-state: [stderr] add support for dynamically enabling/disabling events,
Stefan Hajnoczi <=
- Re: [Qemu-devel] [PATCH v2 10/11] trace-state: [stderr] add support for dynamically enabling/disabling events, Paolo Bonzini, 2011/04/24
- Re: [Qemu-devel] [PATCH v2 10/11] trace-state: [stderr] add support for dynamically enabling/disabling events, Stefan Hajnoczi, 2011/04/24
- Re: [Qemu-devel] [PATCH v2 10/11] trace-state: [stderr] add support for dynamically enabling/disabling events, Lluís, 2011/04/25
- Re: [Qemu-devel] [PATCH v2 10/11] trace-state: [stderr] add support for dynamically enabling/disabling events, Paolo Bonzini, 2011/04/25
- Re: [Qemu-devel] [PATCH v2 10/11] trace-state: [stderr] add support for dynamically enabling/disabling events, Fabien Chouteau, 2011/04/26
- Re: [Qemu-devel] [PATCH v2 10/11] trace-state: [stderr] add support for dynamically enabling/disabling events, Stefan Hajnoczi, 2011/04/26
- Re: [Qemu-devel] [PATCH v2 10/11] trace-state: [stderr] add support for dynamically enabling/disabling events, Paolo Bonzini, 2011/04/26
- Re: [Qemu-devel] [PATCH v2 10/11] trace-state: [stderr] add support for dynamically enabling/disabling events, Lluís, 2011/04/26
[Qemu-devel] [PATCH v2 11/11] trace: enable all events, Lluís, 2011/04/06
[Qemu-devel] [PATCH v2 02/11] docs/tracing.txt: minor documentation fixes, Lluís, 2011/04/06