Re: [Qemu-devel] [RFC][PATCH v2 00/11] trace-state: make the behaviour of "disable" consistent across all backends

[Stefan Hajnoczi]

On Wed, Apr 6, 2011 at 7:33 PM, Lluís <address@hidden> wrote:
> This patch defines the "disable" trace event state to always use the "nop"
> backend.
>
> As a side-effect, all events are now enabled (without "disable") by default, 
> as
> all backends (except "stderr") have programmatic support for dynamically
> (de)activating each trace event.
>
> In order to make this true, the "simple" backend now has a "-trace
> events=<file>" argument to let the user select which events must be enabled 
> from
> the very beginning.
>
> NOTES:
> * Parsing of -trace arguments is not done in the OS-specific frontends.
>
> Signed-off-by: Lluís Vilanova <address@hidden>
> ---
>
> Changes in v2:
>
> * Documentation fixes.
> * Seggregate whitespace/indentation changes.
> * Minor code beautifications.
> * Make all -trace suboptions explicit.
> * Fix minor comments from Stefan.
> * Minor trace-events format fixes.
> * Integrate changes from Fabien.
> * Rebase on qemu.git/master (c8f930c0eeb696d638f4d4bf654e955fa44ff40f).
>
> Lluís Vilanova (11):
>      minor whitespace/indentation fixes
>      docs/tracing.txt: minor documentation fixes
>      trace: [ust] fix generation of 'trace.c' on events without args
>      trace: [trace-events] fix print formats in some events
>      trace: [simple] minor code fixes on conditional compilation
>      trace: generalize the "property" concept in the trace-events file
>      trace-state: always use the "nop" backend on events with the "disable" 
> keyword
>      trace-state: [simple] disable all trace points by default
>      trace-state: [simple] add "-trace events" argument to control initial 
> state
>      trace-state: [stderr] add support for dynamically enabling/disabling 
> events
>      trace: enable all events
>
>
>  Makefile.objs     |    8 +
>  configure         |   33 ++--
>  docs/tracing.txt  |   50 +++--
>  hmp-commands.hx   |   38 ++--
>  monitor.c         |   24 ++-
>  qemu-config.c     |    8 +
>  qemu-options.hx   |   26 ++-
>  scripts/tracetool |  121 +++++++------
>  simpletrace.h     |    7 -
>  stderrtrace.c     |   24 +++
>  stderrtrace.h     |   14 ++
>  trace-events      |  491 
> ++++++++++++++++++++++++++---------------------------
>  vl.c              |  104 ++++++++---
>  13 files changed, 530 insertions(+), 418 deletions(-)
>  create mode 100644 stderrtrace.c
>  create mode 100644 stderrtrace.h

Merged patches 2-4.  I left comments on other patches.
http://repo.or.cz/w/qemu/stefanha.git/shortlog/refs/heads/tracing

This is good work and I look forward to merging the -trace
events=<file> option.  Please try to change only what is necessary,
style issues are subjective.

Stefan