[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] virtio-serial: Fix endianness bug in the config
From: |
Juan Quintela |
Subject: |
Re: [Qemu-devel] [PATCH] virtio-serial: Fix endianness bug in the config space |
Date: |
Mon, 25 Apr 2011 18:40:03 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) |
David Gibson <address@hidden> wrote:
> From: Alexey Kardashevskiy <address@hidden>
>
> The virtio serial specification requres that the values in the config
> space are encoded in native endian of the guest.
> The qemu virtio-serial code did not do conversion to the guest endian
> format what caused problems when host and guest use different format.
>
> This patch corrects the qemu side, correctly doing host-native <->
> guest-native conversions when accessing the config space. This won't
> break any setups that aren't already broken, and fixes the case
> of different host and guest endianness.
>
> Signed-off-by: Alexey Kardashevskiy <address@hidden>
Reviewed-by: Juan Quintela <address@hidden>
It dont' make any change when guest & host has the same endianess.
Later, Juan.