Re: [Qemu-devel] kvm crashes with spice while loading qxl

[Gerd Hoffmann]

On 04/26/11 11:06, Jan Kiszka wrote:
> On 2011-04-26 10:53, Gerd Hoffmann wrote:
> > > Two general issues with dropping the global mutex like this:
> > >    - The caller of mutex_unlock is responsible for maintaining
> > >      cpu_single_env across the unlocked phase (that's related to the
> > >      abort above).
> >
> > This is true for qemu-kvm only, right?
>
> Nope, this applies to both implementations.

Oops.

> > qemu-kvm specific patches which add the cpu_single_env tracking (not
> > polished yet) are here:
> >
> > http://cgit.freedesktop.org/spice/qemu/log/?h=spice.kvm.v28
>
> Cannot spot that quickly: In which way are they specific to qemu-kvm?

cpu_single_env bookeeping.  But if upstream needs that too having 
specific patches is pretty pointless.  I'll go fix it up upstream then.

cheers,
  Gerd