Re: [Qemu-devel] [PATCH] rtl8139: Fix compilation for w32/w64

[Aurelien Jarno]

On Tue, Apr 26, 2011 at 10:17:48AM +0200, Stefan Weil wrote:
> Compilation for Windows needs a different declaration for the
> printf format attribute, so use the macro which was defined for
> this purpose.
> 
> Cc: Benjamin Poirier <address@hidden>
> Signed-off-by: Stefan Weil <address@hidden>
> ---
>  hw/rtl8139.c |    3 +--
>  1 files changed, 1 insertions(+), 2 deletions(-)

Thanks, applied.

> diff --git a/hw/rtl8139.c b/hw/rtl8139.c
> index 623fb0c..b997fe7 100644
> --- a/hw/rtl8139.c
> +++ b/hw/rtl8139.c
> @@ -88,8 +88,7 @@
>  #  define DPRINTF(fmt, ...) \
>      do { fprintf(stderr, "RTL8139: " fmt, ## __VA_ARGS__); } while (0)
>  #else
> -static inline __attribute__ ((format (printf, 1, 2)))
> -    int DPRINTF(const char *fmt, ...)
> +static inline GCC_FMT_ATTR(1, 2) int DPRINTF(const char *fmt, ...)
>  {
>      return 0;
>  }
> -- 
> 1.7.2.5
> 
> 

-- 
Aurelien Jarno                          GPG: 1024D/F1BCDB73
address@hidden                 http://www.aurel32.net