qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] [PATCH 5/6] char: Detect chardev release by NULL handlers a


From: Amit Shah
Subject: [Qemu-devel] [PATCH 5/6] char: Detect chardev release by NULL handlers as well as NULL opaque
Date: Thu, 28 Apr 2011 13:00:52 +0530

Juan says he prefers these extra checks to ensure a user of a chardev is
releasing it.

Requested-by: Juan Quintela <address@hidden>
Signed-off-by: Amit Shah <address@hidden>
---
 qemu-char.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/qemu-char.c b/qemu-char.c
index eaf6571..5e04a20 100644
--- a/qemu-char.c
+++ b/qemu-char.c
@@ -197,7 +197,7 @@ void qemu_chr_add_handlers(CharDriverState *s,
                            IOEventHandler *fd_event,
                            void *opaque)
 {
-    if (!opaque) {
+    if (!opaque && !fd_can_read && !fd_read && !fd_event) {
         /* chr driver being released. */
         ++s->avail_connections;
     }
-- 
1.7.4.4




reply via email to

[Prev in Thread] Current Thread [Next in Thread]