qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] ide/atapi: fix set but unused


From: Paolo Bonzini
Subject: Re: [Qemu-devel] [PATCH] ide/atapi: fix set but unused
Date: Thu, 28 Apr 2011 14:35:03 +0200
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.15) Gecko/20110307 Fedora/3.1.9-0.39.b3pre.fc14 Lightning/1.0b3pre Mnenhy/0.8.3 Thunderbird/3.1.9

On 04/28/2011 02:16 PM, Stefan Weil wrote:

What about using buf instead of packet (no need for extensions, reduces
code by 4 lines)?

Uh, you're right!... I was assuming some side effect later, but after the refactoring this is indeed the only place where packet is used in the function, and it could use buf.

Paolo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]