Re: [Qemu-devel] [PATCH] monitor: add PPC BookE SPRs

[Scott Wood]

On Fri, 29 Apr 2011 14:05:23 +0200
Jan Kiszka <address@hidden> wrote:

> On 2011-04-28 23:01, Scott Wood wrote:
> > +#ifdef KVM_CAP_PPC_BOOKE_SREGS
> > +    if (kvm_check_extension(env->kvm_state, KVM_CAP_PPC_BOOKE_SREGS)) {
> 
> You probably want to cache the result of this syscall during init and
> check that here. There are plenty examples for this pattern around.

OK.

> > +        ret = kvm_vcpu_ioctl(env, KVM_GET_SREGS, &sregs);
> > +        if (ret < 0)
> > +            return ret;
> 
> Please use chechpatch.pl before submitting.

Doh, will fix.

-Scott