Re: [Qemu-devel] [PATCH 02/33] gdbserver: Don't deliver TIMER interrupts when SSTEP_NOIRQ either.

[Blue Swirl]

On Thu, Apr 28, 2011 at 11:50 PM, Richard Henderson <address@hidden> wrote:
> This would affect Sparc as well.
>
> Signed-off-by: Richard Henderson <address@hidden>
> Cc: Blue Swirl <address@hidden>
> ---
>  cpu-exec.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/cpu-exec.c b/cpu-exec.c
> index 395cd8c..e1b85d6 100644
> --- a/cpu-exec.c
> +++ b/cpu-exec.c
> @@ -361,6 +361,7 @@ int cpu_exec(CPUState *env1)
>                     if (unlikely(env->singlestep_enabled & SSTEP_NOIRQ)) {
>                         /* Mask out external interrupts for this step. */
>                         interrupt_request &= ~(CPU_INTERRUPT_HARD |
> +                                               CPU_INTERRUPT_TIMER |

Grepping for CPU_INTERRUPT_TIMER shows that the flag isn't ever set,
only cleared or checked. How
about removing the flag instead?