Re: [Qemu-devel] [PATCHv2 2/4] qxl: add mode to debugprint on destroy primary

[Alon Levy]

On Fri, Apr 29, 2011 at 02:01:57PM +0200, Gerd Hoffmann wrote:
> On 04/28/11 10:29, Alon Levy wrote:
> >---
> >  hw/qxl.c |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> >
> >diff --git a/hw/qxl.c b/hw/qxl.c
> >index 63e295b..ccd820c 100644
> >--- a/hw/qxl.c
> >+++ b/hw/qxl.c
> >@@ -1009,7 +1009,7 @@ static void ioport_write(void *opaque, uint32_t addr, 
> >uint32_t val)
> >          break;
> >      case QXL_IO_DESTROY_PRIMARY:
> >          PANIC_ON(val != 0);
> >-        dprint(d, 1, "QXL_IO_DESTROY_PRIMARY\n");
> >+        dprint(d, 1, "QXL_IO_DESTROY_PRIMARY (%s)\n", 
> >qxl_mode_to_string(d->mode));
> >          qxl_destroy_primary(d);
> >          break;
> >      case QXL_IO_DESTROY_SURFACE_WAIT:
> 
> Squash into the first?  Maybe there are a few more places where a
> pretty-printed mode would be useful?
ok, I'll look for more usage ops and do the squash.

> 
> cheers,
>   Gerd