[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v2 03/10] eepro100: Remove unused structure element
From: |
Stefan Weil |
Subject: |
[Qemu-devel] [PATCH v2 03/10] eepro100: Remove unused structure element |
Date: |
Sat, 30 Apr 2011 22:40:06 +0200 |
cppcheck reports that 'packet' is unused.
It was only used to calculate the size of the preceding data.
Removing it saves a lot of stack space (local variable rx).
Signed-off-by: Stefan Weil <address@hidden>
---
hw/eepro100.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/hw/eepro100.c b/hw/eepro100.c
index 0e22d91..82c6369 100644
--- a/hw/eepro100.c
+++ b/hw/eepro100.c
@@ -173,7 +173,7 @@ typedef struct {
uint32_t rx_buf_addr; /* void * */
uint16_t count;
uint16_t size;
- char packet[MAX_ETH_FRAME_SIZE + 4];
+ /* Ethernet frame data follows. */
} eepro100_rx_t;
typedef enum {
@@ -1738,7 +1738,7 @@ static ssize_t nic_receive(VLANClientState *nc, const
uint8_t * buf, size_t size
/* !!! */
eepro100_rx_t rx;
cpu_physical_memory_read(s->ru_base + s->ru_offset, &rx,
- offsetof(eepro100_rx_t, packet));
+ sizeof(eepro100_rx_t));
uint16_t rfd_command = le16_to_cpu(rx.command);
uint16_t rfd_size = le16_to_cpu(rx.size);
@@ -1769,7 +1769,7 @@ static ssize_t nic_receive(VLANClientState *nc, const
uint8_t * buf, size_t size
assert(!(s->configuration[17] & BIT(0)));
#endif
cpu_physical_memory_write(s->ru_base + s->ru_offset +
- offsetof(eepro100_rx_t, packet), buf, size);
+ sizeof(eepro100_rx_t), buf, size);
s->statistics.rx_good_frames++;
eepro100_fr_interrupt(s);
s->ru_offset = le32_to_cpu(rx.link);
--
1.7.2.5
- [Qemu-devel] [PULL v2] eepro100: Update of patch series (fixes and enhancements), Stefan Weil, 2011/04/30
- [Qemu-devel] [PATCH v2 07/10] eepro100: Support byte/word writes to pointer register, Stefan Weil, 2011/04/30
- [Qemu-devel] [PATCH v2 09/10] eepro100: Support byte read access to general control register, Stefan Weil, 2011/04/30
- [Qemu-devel] [PATCH v2 02/10] eepro100: Remove type casts which are no longer needed, Stefan Weil, 2011/04/30
- [Qemu-devel] [PATCH v2 04/10] eepro100: Pad received short frames, Stefan Weil, 2011/04/30
- [Qemu-devel] [PATCH v2 03/10] eepro100: Remove unused structure element,
Stefan Weil <=
- [Qemu-devel] [PATCH v2 08/10] eepro100: Support byte/word read/write access to MDI control register, Stefan Weil, 2011/04/30
- [Qemu-devel] [PATCH v2 10/10] eepro100: Support 32 bit read/write access to flash register, Stefan Weil, 2011/04/30
- [Qemu-devel] [PATCH v2 06/10] eepro100: Support byte/word writes to port address, Stefan Weil, 2011/04/30
- [Qemu-devel] [PATCH v2 05/10] eepro100: Fix endianness issues, Stefan Weil, 2011/04/30
- [Qemu-devel] [PATCH v2 01/10] eepro100: Avoid duplicate debug messages, Stefan Weil, 2011/04/30