Re: [Qemu-devel] [RFC][PATCH] Import Linux headers for KVM and vhost

[Jan Kiszka]

On 2011-05-03 17:12, Christoph Hellwig wrote:
> On Tue, May 03, 2011 at 04:05:37PM +0200, Jan Kiszka wrote:
>> This helps reducing our build-time checks for feature support in the
>> available Linux kernel headers. And it helps users that do not have
>> sufficiently recent headers installed on their build machine.
>>
>> Header upstate is triggered via 'make update-linux-headers', optionally
>> specifying a kernel directory as source via 'LINUX='.
> 
> Why not make it a shell scripts?  It's not like it's part of the build
> system.  I also think the source tree argument should be mandatory instead
> of grabbing random headers.

Yes, makes sense. I just adopted the kvm-kmod style here which I'm used to.

Jan

-- 
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux