[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] s390x kvm and smp
From: |
Jan Kiszka |
Subject: |
Re: [Qemu-devel] s390x kvm and smp |
Date: |
Wed, 04 May 2011 12:59:06 +0200 |
User-agent: |
Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 |
On 2011-05-04 12:43, Christian Borntraeger wrote:
> Alex,
>
> I have trouble getting kvm smp support running. Turns out that qemu does a kvm
> run even on secondary CPUs which dont have a sane state (initial psw == 0)
> triggering some program faults. Architecturally these cpus are in the stopped
> state, so we should not do KVM_RUN. (these CPUs will be started by a SIGP
> restart later during the boot process)
>
> This patch seems to help (it allows me to boot and use more than 1 cpu)
>
> --- a/cpus.c
> +++ b/cpus.c
> @@ -131,6 +131,10 @@ static void do_vm_stop(int reason)
>
> static int cpu_can_run(CPUState *env)
> {
> + if (env->halted) {
> + return 0;
> + }
> +
> if (env->stop) {
> return 0;
> }
>
> but it does not look like the right solution. What are the proper
> definitions for halted and stopped?
s390 just need to return a meaningful value from
kvm_arch_process_async_events, e.g. env->halted, see other archs.
Jan
--
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux