qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 0/3]: QMP: Introduce inject-nmi command


From: Blue Swirl
Subject: Re: [Qemu-devel] [PATCH 0/3]: QMP: Introduce inject-nmi command
Date: Wed, 4 May 2011 22:28:20 +0300

On Mon, May 2, 2011 at 6:57 PM, Luiz Capitulino <address@hidden> wrote:
> On Sat, 30 Apr 2011 09:33:15 +0300
> Blue Swirl <address@hidden> wrote:
>
>> On Sat, Apr 30, 2011 at 1:40 AM, Luiz Capitulino <address@hidden> wrote:
>> > This series introduces the inject-nmi command for QMP, which sends an
>> > NMI to _all_ guest's CPUs.
>> >
>> > Also note that this series changes the human monitor nmi command to use
>> > the QMP implementation, which means that it now has a DIFFERENT behavior.
>> > Please, check patch 3/3 for details.
>>
>> As discussed earlier, please change the QMP version for future
>> expandability so that instead of single command 'inject-nmi', 'inject'
>> takes parameter 'nmi'. HMP command 'nmi' can remain for now, but
>> 'inject' should be added.
>
> I'm not sure I agree with this, because we risky overloading 'inject' the
> same way we did with the 'change' command.
>
> What's 'inject' supposed to do in the future?

Inject other IRQs, for example inject nmi could become an alias to
something like
inject /address@hidden:l1int
which would be a shorthand for
raise /address@hidden:l1int
lower /address@hidden:l1int

I think we only need a registration framework for IRQs and other signals.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]