[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 3/3] CPUPhysMemoryClient: Batch contiguous ad
From: |
Michael S. Tsirkin |
Subject: |
Re: [Qemu-devel] [PATCH v2 3/3] CPUPhysMemoryClient: Batch contiguous addresses when playing catchup |
Date: |
Thu, 5 May 2011 18:38:44 +0300 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Thu, May 05, 2011 at 05:36:04PM +0200, Jes Sorensen wrote:
> On 05/05/11 17:18, Michael S. Tsirkin wrote:
> >> > A memory size can obviously not be bigger than the maximum physical
> >> > address, so I find it really hard to see how this could overflow.
> > For example, a 4G size does not fit in 32 bits.
>
> That is the only corner case
True.
> you can handle that by -1 if you like.
But then all users need to be updated.
Seems easier to break out of the loop easier.
It's likely not a real problem, certainly not on a pc,
don't know about other systems.
> Jes
>
- [Qemu-devel] [PATCH v2 0/3] CPUPhysMemoryClient: Fixes and batching, Alex Williamson, 2011/05/03
- [Qemu-devel] [PATCH v2 1/3] CPUPhysMemoryClient: Fix typo in phys memory client registration, Alex Williamson, 2011/05/03
- [Qemu-devel] [PATCH v2 2/3] CPUPhysMemoryClient: Pass guest physical address not region offset, Alex Williamson, 2011/05/03
- [Qemu-devel] [PATCH v2 3/3] CPUPhysMemoryClient: Batch contiguous addresses when playing catchup, Alex Williamson, 2011/05/03
- Re: [Qemu-devel] [PATCH v2 3/3] CPUPhysMemoryClient: Batch contiguous addresses when playing catchup, Michael S. Tsirkin, 2011/05/05
- Re: [Qemu-devel] [PATCH v2 3/3] CPUPhysMemoryClient: Batch contiguous addresses when playing catchup, Alex Williamson, 2011/05/05
- Re: [Qemu-devel] [PATCH v2 3/3] CPUPhysMemoryClient: Batch contiguous addresses when playing catchup, Jes Sorensen, 2011/05/05
- Re: [Qemu-devel] [PATCH v2 3/3] CPUPhysMemoryClient: Batch contiguous addresses when playing catchup, Michael S. Tsirkin, 2011/05/05
- Re: [Qemu-devel] [PATCH v2 3/3] CPUPhysMemoryClient: Batch contiguous addresses when playing catchup, Jes Sorensen, 2011/05/05
- Re: [Qemu-devel] [PATCH v2 3/3] CPUPhysMemoryClient: Batch contiguous addresses when playing catchup,
Michael S. Tsirkin <=
- Re: [Qemu-devel] [PATCH v2 3/3] CPUPhysMemoryClient: Batch contiguous addresses when playing catchup, Jes Sorensen, 2011/05/05
- Re: [Qemu-devel] [PATCH v2 3/3] CPUPhysMemoryClient: Batch contiguous addresses when playing catchup, Michael S. Tsirkin, 2011/05/05
- Re: [Qemu-devel] [PATCH v2 3/3] CPUPhysMemoryClient: Batch contiguous addresses when playing catchup, Michael S. Tsirkin, 2011/05/05
- Re: [Qemu-devel] [PATCH v2 3/3] CPUPhysMemoryClient: Batch contiguous addresses when playing catchup, Alex Williamson, 2011/05/24
- Re: [Qemu-devel] [PATCH v2 3/3] CPUPhysMemoryClient: Batch contiguous addresses when playing catchup, Michael S. Tsirkin, 2011/05/25
Re: [Qemu-devel] [PATCH v2 0/3] CPUPhysMemoryClient: Fixes and batching, Michael S. Tsirkin, 2011/05/05