qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2 04/10] eepro100: Pad received short frames


From: Stefan Weil
Subject: Re: [Qemu-devel] [PATCH v2 04/10] eepro100: Pad received short frames
Date: Thu, 05 May 2011 18:19:48 +0200
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.14) Gecko/20110223 Thunderbird/3.1.8

Am 05.05.2011 15:00, schrieb Michael S. Tsirkin:
On Sat, Apr 30, 2011 at 10:40:07PM +0200, Stefan Weil wrote:
QEMU sends frames smaller than 60 bytes to ethernet nics.
This should be fixed in the networking code because normally
such frames are rejected by real NICs and their emulations.
To avoid this behaviour, other NIC emulations pad received
frames. This patch enables this workaround for eepro100, too.

All related code is marked with CONFIG_PAD_RECEIVED_FRAMES,
so emulation of the correct handling for short frames can
be restored as soon as QEMU's networking code is fixed.

Signed-off-by: Stefan Weil<address@hidden>
Applied, I tweaked the comment a bit as we don't intend
to change it in qemu. But go ahead and keep the ifdef around
if you like.

The new comment is ok, thanks.

Cheers,
Stefan W.





reply via email to

[Prev in Thread] Current Thread [Next in Thread]