|
From: | Paul Brook |
Subject: | Re: [Qemu-devel] [PATCH 4/7] target-arm: Refactor int-float conversions |
Date: | Fri, 6 May 2011 15:09:36 +0100 |
User-agent: | KMail/1.13.5 (Linux/2.6.38-2-amd64; KDE/4.4.5; x86_64; ; ) |
> The Neon versions of int-float conversions need their own helper routines > because they must use the "standard FPSCR" rather than the default one. > Refactor the helper functions to make it easy to add the neon versions. > While we're touching the code, move the helpers to op_helper.c so that > we can use the global env variable rather than passing it as a parameter. IMO this is going in the wrong direction. We should in aiming for less implicit accesses to cpu state, not more. Maybe better would be to explicitly pass a pointer the fp status. That way you don't even need separate VFP and NEON variants of these routines. Paul
[Prev in Thread] | Current Thread | [Next in Thread] |