Re: [Qemu-devel] [PATCH 5/6] PPC: Implement e500 (FSL) MMU

[Scott Wood]

On Fri, 6 May 2011 20:33:24 +0200
Alexander Graf <address@hidden> wrote:

> On 06.05.2011, at 19:40, Scott Wood wrote:
> 
> > OK, it looked like it was being limited to only FSL.  I missed that
> > PPC_BOOKE and PPC2_BOOKE_FSL are the same "kind" of flags despite being in
> > different words.  Does PPC_BOOKE not refer to things that are common to all
> > booke?  Why do the individual implementations of booke need to be listed?
> 
> Well, the PPC_BOOKE flag was also used for the 440 tlb modification opcodes, 
> which are different for 2.06. So I just introduced a new one :). We could of 
> course also introduce yet another flag for 440s and define specific 
> instructions individually, but I don't really see it buying us too much for 
> now.

It would help reduce confusion if PPC_BOOKE really meant booke, and not
440. :-)

-Scott